Skip to content

delete old TODO #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion internal/scti/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,6 @@ func addChainInternal(ctx context.Context, opts *HandlerOptions, log *log, w htt

// As the Log server has definitely got the Merkle tree leaf, we can
// generate an SCT and respond with it.
// TODO(phboneff): this should work, but double check
sct, err := log.signSCT(&loggedLeaf)
if err != nil {
return http.StatusInternalServerError, fmt.Errorf("failed to generate SCT: %s", err)
Expand Down
2 changes: 0 additions & 2 deletions internal/scti/signatures.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ func (cts *cpSigner) Sign(msg []byte) ([]byte, error) {
return nil, fmt.Errorf("checkpoint's origin %s doesn't match signer's origin %s", ckpt.Origin, cts.origin)
}

// TODO(phboneff): make sure that it's ok to generate the timestamp here
t := uint64(cts.timeSource.Now().UnixMilli())
sig, err := buildCp(cts.sthSigner, ckpt.Size, t, ckpt.Hash[:])
if err != nil {
Expand Down Expand Up @@ -240,7 +239,6 @@ func NewCpSigner(cs crypto.Signer, origin string, timeSource TimeSource) (note.S

// getCTLogID takes a log public key and returns the LogID. (see RFC 6962 S3.2)
// In CT V1 the log id is a hash of the public key.
// TODO(phboneff): migrate to the logid package
func getCTLogID(pk crypto.PublicKey) ([sha256.Size]byte, error) {
pubBytes, err := x509.MarshalPKIXPublicKey(pk)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion internal/types/rfc6962/rfc6962.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ type ASN1Cert struct {
}

// LogID holds the hash of the Log's public key (section 3.2).
// TODO(pphaneuf): Users should be migrated to the one in the logid package.
type LogID struct {
KeyID [sha256.Size]byte
}
Expand Down
Loading