Skip to content

Test that issuers are populated correctly #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

phbnf
Copy link
Collaborator

@phbnf phbnf commented Apr 8, 2025

Towards #103

@phbnf phbnf requested a review from roger2hk April 8, 2025 16:12
@phbnf phbnf marked this pull request as ready for review April 8, 2025 16:12
t.Errorf("Failed to read issuer at %q: %v", issPath, err)
}
if !bytes.Equal(gotIss, wantIss.Raw) {
t.Errorf("Issuer mismatch) got %s, want %s", gotIss, wantIss.Raw)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Errorf("Issuer mismatch) got %s, want %s", gotIss, wantIss.Raw)
t.Errorf("Issuer mismatch: got %s, want %s", gotIss, wantIss.Raw)

t.Errorf("Failed to read issuer at %q: %v", issPath, err)
}
if !bytes.Equal(gotIss, wantIss.Raw) {
t.Errorf("Issuer mismatch) got %s, want %s", gotIss, wantIss.Raw)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Errorf("Issuer mismatch) got %s, want %s", gotIss, wantIss.Raw)
t.Errorf("Issuer mismatch: got %s, want %s", gotIss, wantIss.Raw)

@phbnf phbnf force-pushed the fingerprintstest branch from b1907a2 to ea6fba2 Compare April 8, 2025 16:53
@phbnf phbnf merged commit 9a777ac into transparency-dev:main Apr 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants