Find a new home for some functions #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roger2hk
reviewed
Apr 9, 2025
| func validateChain(rawChain [][]byte, validationOpts ChainValidationOpts) ([]*x509.Certificate, error) { | ||
| func (opts ChainValidationOpts) validateChain(rawChain [][]byte) ([]*x509.Certificate, error) { |
There was a problem hiding this comment.
It sounds weird to add the validation function to the ChainValidationOpts type which is supposed to store the options.
There was a problem hiding this comment.
Ah sorry I had not seen this comment! Your comment is on point: it's actually the next pr in the chain: phbnf/tesseract@functionsmove...phbnf:static-ct:interfaceverifier. This next PR actually goes further and defines an interface. I did not send it in this PR to make reviewing easier: this one just moves methods, then I'll define interface and rename everything.
There was a problem hiding this comment.
Great. I'm looking forward to reviewing the next PR.
# Conflicts: # internal/hammer/loadtest/workers.go # Conflicts: # internal/scti/handlers.go
roger2hk
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #244
entryFromChain:worker.go+handlers.go-->x509util/ct.goverifyAddChain:handlers.go-->chain_validation.govalidateChainandverifyAddChain: functions to methods ofChainValidationOpts