Support GCP Secret Manager for signer key pair #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbnf
reviewed
Nov 8, 2024
phbnf
reviewed
Nov 8, 2024
AlCutter
reviewed
Nov 8, 2024
phbnf
reviewed
Nov 8, 2024
phbnf
reviewed
Nov 8, 2024
roger2hk
force-pushed
the
gcp-signer-secret-manager
branch
from
d096277 to
c2782bf
Compare
roger2hk
force-pushed
the
gcp-signer-secret-manager
branch
from
c2782bf to
6576b98
Compare
AlCutter
reviewed
Nov 8, 2024
phbnf
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6.
This pull request adds the GCP Secret Manager for storing the signer key pair. The terraform configs are included for the GCP testing environment.
Note that only ECDSA key is supported. RSA key is NOT supported.