Skip to content

Add missing secretmanager project service and dependencies #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add missing secretmanager project service and dependencies #52

merged 1 commit into from
Nov 13, 2024

Conversation

roger2hk
Copy link
Contributor

#6

@roger2hk roger2hk requested review from phbnf and AlCutter November 13, 2024 00:05
AlCutter
AlCutter approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@AlCutter AlCutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like this storage module name is becoming increasingly inaccurate though, might be worth a TODO to have a ponder on renaming it at some point in the future?

@AlCutter
Copy link
Collaborator

Feels like this storage module name is becoming increasingly inaccurate though, might be worth a TODO to have a ponder on renaming it at some point in the future?

Ah, that looks like what #51 is about - great minds!
Carry on :)

@roger2hk roger2hk merged commit 5816176 into transparency-dev:main Nov 13, 2024
7 checks passed
@roger2hk roger2hk deleted the gcp-secret-manager branch November 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phbnf phbnf phbnf approved these changes

@AlCutter AlCutter AlCutter approved these changes

Assignees

@phbnf phbnf

@AlCutter AlCutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roger2hk @AlCutter @phbnf