Skip to content

Remove artifact registry module from GCP conformance CI #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion deployment/live/gcp/ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## Overview

This config uses the [gcp/conformance](/deployment/modules/gcp/conformance) module to
define a CI environment to run the SCTFE, backed by Trillian Tessera.
define a CI environment to run the SCTFE on Cloud Run, backed by Trillian Tessera.

At a high level, this environment consists of:
- One Spanner instance with two databases:
Expand All @@ -13,6 +13,10 @@ At a high level, this environment consists of:
- Secret Manager
- Cloud Run

### Automatic Deployment

This GCP SCTFE conformance CI environment is designed to be deployed by the Cloud Build ([Terraform module](/deployment/modules/gcp/cloudbuild/), [Terragrunt configuration](/deployment/live/gcp/cloudbuild/prod/)).

### Manual Deployment

First authenticate via `gcloud` as a principle with sufficient ACLs for
Expand All @@ -30,6 +34,8 @@ export GOOGLE_REGION={VALUE} # e.g: us-central1
unset TESSERA_BASE_NAME
```

You need an Artifact Registry repository to store container images; adapt the configs and commands below to use your registry of choice. The rest of these instructions assume that the repository is hosted on GCP, and called `${GOOGLE_REGION}-docker.pkg.dev/${GOOGLE_PROJECT}/docker-ci`. For reference, here's a [terraform module](/deployment/modules/gcp/artifactregistry/) you can use to set up such a registry.

Build and push the Docker image to Artifact Registry repository:

```sh
Expand Down
7 changes: 0 additions & 7 deletions deployment/modules/gcp/conformance/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@ terraform {
backend "gcs" {}
}

module "artifactregistry" {
source = "../artifactregistry"

location = var.location
docker_env = var.docker_env
}

module "storage" {
source = "../storage"

Expand Down
Loading