Clean serialize.go #84
Conversation
signatures.go
Outdated
| "golang.org/x/mod/sumdb/note" | ||
|
|
||
| ct "github.com/google/certificate-transparency-go" | ||
| ) | ||
|
|
||
| const millisPerNano int64 = 1000 * 1000 |
There was a problem hiding this comment.
Aren't there approximately zero milliseconds per nanosecond, did you mean nanosPerMilli? :)
If so, could this be ... = time.Millisecond / time.Nanosecond?
There was a problem hiding this comment.
Maybe! This is not new code, I'm blindly migrating it from structures.go. Fixed!
There was a problem hiding this comment.
(did you mean to also export it?)
phbnf
force-pushed
the
signatures
branch
2 times, most recently
from
ca22230 to
9e9103b
Compare
signatures.go
Outdated
| "golang.org/x/mod/sumdb/note" | ||
|
|
||
| ct "github.com/google/certificate-transparency-go" | ||
| ) | ||
|
|
||
| const NanosPerMilli int64 = int64(time.Millisecond / time.Nanosecond) |
There was a problem hiding this comment.
Did you mean to export it BTW?
There was a problem hiding this comment.
Woopsie, thanks. As a general comment, the repo needs a good clean-up of exported / unexported stuff as well. I don't want to do this straight away though first I'll re-organize and simplify the code, then I'll carve a few things into an internal/ directory, and then export / unexport accordingly.
Towards #5
This PR cleans serialize.go: dedup related code moves to dedup.go. Since the remaining code is signature related, we can then rename serialize.go to signatures.go, and move