Separate chain validation, ct log and http server #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # config.go
# Conflicts: # cmd/gcp/main.go # Conflicts: # config.go
# Conflicts: # config_test.go # Conflicts: # ctlog_test.go # Conflicts: # ctlog.go # Conflicts: # config.go # Conflicts: # ctlog.go
roger2hk
approved these changes
Jan 21, 2025
ctlog.go
Outdated
| Signer crypto.Signer | ||
| // CertValidationOpts contains various parameters for certificate chain | ||
| origin string | ||
| // Signs SCTs. |
There was a problem hiding this comment.
Suggested change
| // Signs SCTs. | |
| // signSCT signs SCTs. |
handlers.go
Outdated
Comment on lines
196
to
197
| // signer signs SCTs | ||
| signSCT signSCT |
There was a problem hiding this comment.
Do you want to call this signer or signSCT?
There was a problem hiding this comment.
Ah, thanks! Was called signer, and I then renamed it to signSCT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5
This PR draws boundaries between: