-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse default const parameters #255
Merged
maxbrunsfeld
merged 4 commits into
tree-sitter:master
from
m4rch3n1ng:const-param-defaults
Feb 28, 2025
Merged
parse default const parameters #255
maxbrunsfeld
merged 4 commits into
tree-sitter:master
from
m4rch3n1ng:const-param-defaults
Feb 28, 2025
+93,157
−94,296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks so much for tracking the progress on the rustc files. |
72d0a56
to
778d83e
Compare
added the second part with |
778d83e
to
dff6690
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more naming change. Thanks for addressing all of this feedback!
dff6690
to
dba80e1
Compare
instead of having two seperate type_parameter rules: `constrained_type_parameter` and `optional_type_parameter`, combine them into one rule with two `optional`s.
dba80e1
to
5269fa0
Compare
maxbrunsfeld
approved these changes
Feb 28, 2025
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #228.
parse const parameter default assignments. specified in the reference it takes blocks, identifiers and literals (with optional minus).
also fixes some more of the mismatches from #229:
diff