fix(core): prevent homescreen flickering on Cancel message #5027
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matejcik
reviewed
May 11, 2025
matejcik
reviewed
May 12, 2025
| @@ -136,14 +136,14 @@ def kill_default() -> None: | |||
| default_task.close() | |||
|
|
|||
|
|
|||
| def close_others() -> None: | |||
| def close_others(close_default: bool = True) -> None: | |||
There was a problem hiding this comment.
please add a description of the option to the docstring
matejcik
reviewed
May 12, 2025
romanz
force-pushed
the
romanz/fix-homescreen
branch
from
ff73235 to
4ee8985
Compare
|
Unfortunately, the above approach doesn't clear the locking animation if |
|
OTOH, maybe adding layout polling API would be a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't fade homescreen in case of
Cancel.