-
-
Notifications
You must be signed in to change notification settings - Fork 691
Update VerticalMenu swiping behavior for Eckhart #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ibz
requested changes
Apr 15, 2025
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/device_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/device_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu_screen.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu.rs
Outdated
Show resolved
Hide resolved
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu.rs
Outdated
Show resolved
Hide resolved
Rebasing due to major change in the base branch |
b840a91
to
0758d08
Compare
ibz
reviewed
Apr 23, 2025
core/embed/rust/src/ui/layout_eckhart/firmware/vertical_menu.rs
Outdated
Show resolved
Hide resolved
ibz
approved these changes
Apr 23, 2025
dd658ea
to
390943b
Compare
Leave event processing to the Vertical Menu Disable scrolling when the menu fits the screen
This simplifies the implementation of the verical menu
390943b
to
2ae2be5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
VerticalMenu
componentVerticalMenu
fitting/not fitting its boundsupdate_screen
forVerticalMenuScreen
. It has to be called in theDeviceMenuScreen
whenever the screen is switched.n-th
item by swiping upn-1
times and then clicking on the 1st item area no matter what the menu item height is. The behavior can be tested by spawning the emulator with disabled animations:./emu.py -a