Skip to content

Update VerticalMenu swiping behavior for Eckhart #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Apr 11, 2025

This PR:

  • Improves event processing for the VerticalMenu component
  • Switches swiping on/off based on the VerticalMenu fitting/not fitting its bounds
  • Implements function update_screen for VerticalMenuScreen. It has to be called in the DeviceMenuScreen whenever the screen is switched.
  • Adds swiping functionality for testing purposes when animations are disabled:
    • The menu is swipable until the the last item is visible on top of the menu area (even if an entire menu fits the screen).
    • This way the device tests can select n-th item by swiping up n-1 times and then clicking on the 1st item area no matter what the menu item height is. The behavior can be tested by spawning the emulator with disabled animations:./emu.py -a

@bieleluk bieleluk added the T3W1 label Apr 11, 2025
@bieleluk bieleluk added this to the UI Eckhart milestone Apr 11, 2025
@bieleluk bieleluk requested a review from ibz April 11, 2025 14:42
@bieleluk bieleluk self-assigned this Apr 11, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Apr 11, 2025
Copy link

github-actions bot commented Apr 11, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3W1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@bieleluk bieleluk marked this pull request as ready for review April 12, 2025 10:54
@bieleluk bieleluk requested a review from prusnak as a code owner April 12, 2025 10:54
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🏃‍♀️ In progress in Firmware Apr 15, 2025
@obrusvit obrusvit requested a review from matejcik as a code owner April 16, 2025 10:43
@bieleluk
Copy link
Contributor Author

Rebasing due to major change in the base branch

@bieleluk bieleluk force-pushed the bieleluk/eckhart-vertical-menu branch from b840a91 to 0758d08 Compare April 17, 2025 08:21
@bieleluk bieleluk requested a review from ibz April 22, 2025 08:01
@bieleluk bieleluk added the translations Put this label on a PR to run tests in all languages label Apr 23, 2025
@bieleluk bieleluk force-pushed the bieleluk/eckhart-vertical-menu branch 2 times, most recently from dd658ea to 390943b Compare April 23, 2025 20:12
Leave event processing to the Vertical Menu
Disable scrolling when the menu fits the screen
This simplifies the implementation of the verical menu
@bieleluk bieleluk force-pushed the bieleluk/eckhart-vertical-menu branch from 390943b to 2ae2be5 Compare April 28, 2025 10:16
@bieleluk bieleluk merged commit 8906d8c into ui-eckhart Apr 28, 2025
147 of 163 checks passed
@bieleluk bieleluk deleted the bieleluk/eckhart-vertical-menu branch April 28, 2025 10:55
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Firmware Apr 28, 2025
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Firmware May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T3W1 translations Put this label on a PR to run tests in all languages
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

2 participants