Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for Alluxio file system #23269

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

jja725
Copy link
Member

@jja725 jja725 commented Sep 3, 2024

Description

Add docs for Alluxio file system.

Additional context and related issues

Docs for #21603

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2024
@github-actions github-actions bot added the docs label Sep 3, 2024
@jja725 jja725 force-pushed the add-alluxio-document branch from 05c2282 to 2821f65 Compare September 3, 2024 22:19
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Sep 25, 2024
@mosabua mosabua self-assigned this Sep 25, 2024
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Sep 25, 2024
@jja725 jja725 force-pushed the add-alluxio-document branch from 2821f65 to cbda74f Compare September 26, 2024 18:59
@mosabua mosabua force-pushed the add-alluxio-document branch from cbda74f to d9b8174 Compare September 26, 2024 19:52
@mosabua mosabua changed the title Add Alluxio Filesystem document Add docs for Alluxio file system Sep 26, 2024
@mosabua mosabua force-pushed the add-alluxio-document branch from d9b8174 to 6a75e05 Compare September 26, 2024 19:57
@mosabua
Copy link
Member

mosabua commented Sep 26, 2024

I did a bunch of updates for grammar and setup so the docs actually build and work. Left a few questions but in general this looks good. I am wondering if we should have a minimal example of the properties file though .. and then link to the Alluxio docs for me.

Also please review all content I updated and update as needed and push further changes @jja725

@jja725 jja725 force-pushed the add-alluxio-document branch from 6a75e05 to 90354e1 Compare September 26, 2024 20:28
@jja725
Copy link
Member Author

jja725 commented Sep 26, 2024

I did a bunch of updates for grammar and setup so the docs actually build and work. Left a few questions but in general this looks good. I am wondering if we should have a minimal example of the properties file though .. and then link to the Alluxio docs for me.

Also please review all content I updated and update as needed and push further changes @jja725

Added example property file. The updates LGTM, thanks for collaborating on this!

@jja725 jja725 force-pushed the add-alluxio-document branch from 90354e1 to 1234d73 Compare September 26, 2024 22:06
@jja725 jja725 force-pushed the add-alluxio-document branch from 1234d73 to d982273 Compare September 26, 2024 22:25
@mosabua mosabua removed their assignment Sep 27, 2024
Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@mosabua mosabua force-pushed the add-alluxio-document branch from d982273 to 3ff0c42 Compare September 27, 2024 15:55
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you @jja725

@mosabua mosabua merged commit ad4375e into trinodb:master Sep 27, 2024
3 of 8 checks passed
@github-actions github-actions bot added this to the 460 milestone Sep 27, 2024
@mosabua mosabua mentioned this pull request Sep 27, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed docs stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Development

Successfully merging this pull request may close these issues.

2 participants