Skip to content

Commit

Permalink
Add logging and fix some error checking
Browse files Browse the repository at this point in the history
  • Loading branch information
debermudez committed Mar 6, 2024
1 parent 17c3f05 commit baf41a5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 14 deletions.
6 changes: 5 additions & 1 deletion src/c++/perf_analyzer/genai-pa/genai_pa/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,13 @@ def report_output(metrics: LLMProfileData, args):
if "concurrency_range" in args:
infer_mode = "concurrency"
load_level = args.concurrency_range
else:
elif "request_rate_range" in args:
infer_mode = "request_rate"
load_level = args.request_rate_range
else:
raise GenAiPAException(
"Neither concurrency_range nor request_rate_range was found in args when reporting metrics"
)
# TODO: metrics reporter class that consumes Stats class for nicer formatting
print(metrics.get_statistics(infer_mode, int(load_level)))

Expand Down
17 changes: 4 additions & 13 deletions src/c++/perf_analyzer/genai-pa/genai_pa/parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,6 @@ def _update_load_manager_args(args: argparse.ArgumentParser) -> argparse.Argumen
return args


def _verify_valid_arg_combination(
args: argparse.ArgumentParser,
) -> argparse.ArgumentParser:
# Verify protocol and default url match
if getattr(args, "i") == "grpc" and getattr(args, "u") == DEFAULT_HTTP_URL:
setattr(args, "u", DEFAULT_GRPC_URL)

return args


### Handlers ###


Expand Down Expand Up @@ -231,11 +221,12 @@ def parse_args(argv=None):
_add_dataset_args(parser)

args, extra_args = parser.parse_known_args(argv)
# strip off the "--" demarking the pass through arguments
extra_args = extra_args[1:]
if extra_args:
# strip off the "--" demarking the pass through arguments
extra_args = extra_args[1:]
logger.info(f"Additional pass through args: {extra_args}")

args = _update_load_manager_args(args)
args = _verify_valid_arg_combination(args)
args = _prune_args(args)

return args, extra_args

0 comments on commit baf41a5

Please sign in to comment.