Address comment #487
Merged
Address comment #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgerdesnv
reviewed
Mar 6, 2024
tgerdesnv
reviewed
Mar 6, 2024
tgerdesnv
added a commit
that referenced
this pull request
Mar 6, 2024
* Address comment * Update src/c++/perf_analyzer/client_backend/openai/openai_client.cc * Update src/c++/perf_analyzer/client_backend/openai/http_client.cc * formatting --------- Co-authored-by: Timothy Gerdes <50968584+tgerdesnv@users.noreply.github.com> Co-authored-by: tgerdes <tgerdes@nvidia.com>
tgerdesnv
added a commit
that referenced
this pull request
Mar 6, 2024
* Add openai service-kind and add endpoint to CLI * Add openai to model parser * OpenAI client backend + cmake * Create OpenAI backend * New JSON datatype for PA. Show json data available at http_client level * Add an output to OpenAI models * Add OpenAI client (#482) * Add OpenAI client * Address comment * Pass endpoint to openai client * Resolve fixmes * update copyright years * more cleanup * Update src/c++/perf_analyzer/command_line_parser.cc Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com> * remove 'file' from top of files * clean up help message and add endpoint to help * Fix client stats * remove unused fn * Assert on json input format * Use a single SEND_END point * Add sync assert. Add OPENAI to helper fn * remove unused typedef * Add batch size assert * Address comment (#487) * Address comment * Update src/c++/perf_analyzer/client_backend/openai/openai_client.cc * Update src/c++/perf_analyzer/client_backend/openai/http_client.cc * formatting --------- Co-authored-by: Timothy Gerdes <50968584+tgerdesnv@users.noreply.github.com> Co-authored-by: tgerdes <tgerdes@nvidia.com> * Make copy of exported data so it isn't corrupted (#488) --------- Co-authored-by: oandreeva-nv <oandreeva@nvidia.com> Co-authored-by: GuanLuo <41310872+GuanLuo@users.noreply.github.com> Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com>
debermudez
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Add openai service-kind and add endpoint to CLI * Add openai to model parser * OpenAI client backend + cmake * Create OpenAI backend * New JSON datatype for PA. Show json data available at http_client level * Add an output to OpenAI models * Add OpenAI client (#482) * Add OpenAI client * Address comment * Pass endpoint to openai client * Resolve fixmes * update copyright years * more cleanup * Update src/c++/perf_analyzer/command_line_parser.cc Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com> * remove 'file' from top of files * clean up help message and add endpoint to help * Fix client stats * remove unused fn * Assert on json input format * Use a single SEND_END point * Add sync assert. Add OPENAI to helper fn * remove unused typedef * Add batch size assert * Address comment (#487) * Address comment * Update src/c++/perf_analyzer/client_backend/openai/openai_client.cc * Update src/c++/perf_analyzer/client_backend/openai/http_client.cc * formatting --------- Co-authored-by: Timothy Gerdes <50968584+tgerdesnv@users.noreply.github.com> Co-authored-by: tgerdes <tgerdes@nvidia.com> * Make copy of exported data so it isn't corrupted (#488) --------- Co-authored-by: oandreeva-nv <oandreeva@nvidia.com> Co-authored-by: GuanLuo <41310872+GuanLuo@users.noreply.github.com> Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com>
debermudez
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add openai service-kind and add endpoint to CLI * Add openai to model parser * OpenAI client backend + cmake * Create OpenAI backend * New JSON datatype for PA. Show json data available at http_client level * Add an output to OpenAI models * Add OpenAI client (#482) * Add OpenAI client * Address comment * Pass endpoint to openai client * Resolve fixmes * update copyright years * more cleanup * Update src/c++/perf_analyzer/command_line_parser.cc Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com> * remove 'file' from top of files * clean up help message and add endpoint to help * Fix client stats * remove unused fn * Assert on json input format * Use a single SEND_END point * Add sync assert. Add OPENAI to helper fn * remove unused typedef * Add batch size assert * Address comment (#487) * Address comment * Update src/c++/perf_analyzer/client_backend/openai/openai_client.cc * Update src/c++/perf_analyzer/client_backend/openai/http_client.cc * formatting --------- Co-authored-by: Timothy Gerdes <50968584+tgerdesnv@users.noreply.github.com> Co-authored-by: tgerdes <tgerdes@nvidia.com> * Make copy of exported data so it isn't corrupted (#488) --------- Co-authored-by: oandreeva-nv <oandreeva@nvidia.com> Co-authored-by: GuanLuo <41310872+GuanLuo@users.noreply.github.com> Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com>
mc-nv
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add openai service-kind and add endpoint to CLI * Add openai to model parser * OpenAI client backend + cmake * Create OpenAI backend * New JSON datatype for PA. Show json data available at http_client level * Add an output to OpenAI models * Add OpenAI client (#482) * Add OpenAI client * Address comment * Pass endpoint to openai client * Resolve fixmes * update copyright years * more cleanup * Update src/c++/perf_analyzer/command_line_parser.cc Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com> * remove 'file' from top of files * clean up help message and add endpoint to help * Fix client stats * remove unused fn * Assert on json input format * Use a single SEND_END point * Add sync assert. Add OPENAI to helper fn * remove unused typedef * Add batch size assert * Address comment (#487) * Address comment * Update src/c++/perf_analyzer/client_backend/openai/openai_client.cc * Update src/c++/perf_analyzer/client_backend/openai/http_client.cc * formatting --------- Co-authored-by: Timothy Gerdes <50968584+tgerdesnv@users.noreply.github.com> Co-authored-by: tgerdes <tgerdes@nvidia.com> * Make copy of exported data so it isn't corrupted (#488) --------- Co-authored-by: oandreeva-nv <oandreeva@nvidia.com> Co-authored-by: GuanLuo <41310872+GuanLuo@users.noreply.github.com> Co-authored-by: dyastremsky <58150256+dyastremsky@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.