Bump min cxx standard to 17 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuanLuo
approved these changes
Dec 28, 2023
oandreeva-nv
force-pushed
the
oandreeva_upgrade_cxx_standard_17
branch
from
439a143 to
5d2f4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of the series PRs to update Triton to C++17 standard.
Introduced logic: either set
TRITON_MIN_CXX_STANDARDto 17 or use cached value. Later,TRITON_MIN_CXX_STANDARDis used to set min required standard throughtarget_compile_features.Note:
target_compile_featuressets minimum required CXX standardDuring build if the
default standard==min standard,-std=...flag is not printedIf, for example,
min standardis higher thandefault,-std=...flag will be added (tested locally with setting-DTRITON_MIN_CXX_STANDARDto 20)