Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve decoupled shm handling #337

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Improve decoupled shm handling #337

merged 5 commits into from
Jan 19, 2024

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Jan 17, 2024 •
edited
Loading

Related PR: triton-inference-server/server#6803

Free decoupled shm memory as soon as the memory will not be accessed any more.

@kthui kthui mentioned this pull request Jan 17, 2024
Merged
@kthui kthui marked this pull request as ready for review January 18, 2024 18:25
rmccorm4
rmccorm4 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@rmccorm4 rmccorm4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see a 1-line fix!

Is this the small "growth" (~dozen bytes or so) we saw consistently in this test? Or does it address any other growths or issues as well?

@kthui
Copy link
Contributor Author

kthui commented Jan 18, 2024

Is this the small "growth" (~dozen bytes or so) we saw consistently in this test? Or does it address any other growths or issues as well?

It's the consistent small growth on the decoupled IO test. Might fixed other decoupled issue, but I didn't test for it explicitly.

krishung5
krishung5 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@krishung5 krishung5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Tabrizian
Tabrizian approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Tabrizian Tabrizian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not really a leak based on the offline conversation so perhaps change the PR title to
"Release received message to avoid shm probe failures".

@kthui kthui changed the title Fix decoupled shm leak Fix decoupled shm behavior Jan 19, 2024
@kthui kthui changed the title Fix decoupled shm behavior Improve decoupled shm handling Jan 19, 2024
@kthui kthui merged commit 37d2902 into main Jan 19, 2024
3 checks passed
@kthui kthui deleted the jacky-shm branch January 19, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrizian Tabrizian Tabrizian approved these changes

@rmccorm4 rmccorm4 rmccorm4 approved these changes

@krishung5 krishung5 krishung5 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kthui @Tabrizian @rmccorm4 @krishung5