-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: python backend support for numpy>=2 #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's get a 2nd opinion from Kris or Jacky before merging. Also if it makes sense, let's enable numpy>=2
install for something like L0_backend_python
to confirm it works and catch any edge cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm! +1 on enabling numpy>=2 install L0_backend_python test.
@KrishnanPrash , I still faced the issue with But shouldn't numpy=2.1.2 with pybind11=2.13.6 work as you have mentioned? Let me know if you need more details about my code! |
Testing PR: triton-inference-server/server#7756 |
my numpy is1.26.4, downgrading numpy to 1.25.1 is not work for me |
Updated the PyBind11 version from
v2.10.0
tov2.12.0
, becausev2.12
supportsnumpy 2
(Release Notes).Before this update, if
numpy>=2.x
was installed in the same environment, performing inference requests would lead to error messages, such as:or