Update the symlink #144
Merged
Update the symlink #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc-nv
reviewed
Jan 10, 2025
| COMMAND /bin/sh -c "docker run --name libjpeg-${random_id} ${TRITON_PYTORCH_DOCKER_IMAGE} find /usr/lib64 /usr/local/lib/python3.12/dist-packages/torchvision.libs/ -name libjpeg*.so* -type f -exec cp -v {} /tmp/libjpeg.so \\; || true" | ||
| COMMAND docker cp libjpeg-${random_id}:/tmp/libjpeg.so libjpeg.so | ||
| COMMAND /bin/sh -c "docker run --name libpng-${random_id} ${TRITON_PYTORCH_DOCKER_IMAGE} find /usr/lib64 /usr/local/lib/python3.12/dist-packages/torchvision.libs/ -name libpng*.so* -type f -exec cp -v {} /tmp/libpng16.so \\; || true" | ||
| COMMAND docker cp libpng-${random_id}:/tmp/libpng16.so libpng16.so |
There was a problem hiding this comment.
This change was introduced due to issue with library provided to us in RHEL system.
Can you confirm that the path is valid for RHEL?
There was a problem hiding this comment.
Ack. Yet to verify this.
There was a problem hiding this comment.
ticket 879 created with P0 priority to verify this.
mc-nv
pushed a commit
that referenced
this pull request
Jan 31, 2025
mc-nv
added a commit
that referenced
this pull request
Feb 4, 2025
* Update the symlink (#144) * Downgrade patchelf version from 0.18.0 to 0.17.2 due to patchelf regression (#145) Patchelf shipped a regression in 0.18.0 and has since yanked the pypi release pointing to 0.17.2 as the most recent version. However, 0.18.0 is still the version shipped in both the apt and yum repositories, thus we must use pip to install the version we want. See mayeut/patchelf-pypi#87 --------- Co-authored-by: Pavithra Vijayakrishnan <160681768+pvijayakrish@users.noreply.github.com> Co-authored-by: Kyle McGill <101670481+nv-kmcgill53@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.