-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add tutorials on speculative decoding main page and EAGLE sub page #131
base: main
Are you sure you want to change the base?
Conversation
--input-file /data/converted_humaneval.jsonl \ | ||
--tokenizer /hf-models/vicuna-7b-v1.3/ \ | ||
--concurrency 1 \ | ||
--measurement-interval 4000 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend to use request-rate option rather measurement interval as for long tests these are often requires longer stabalization window.
We are recommending GenAI-perf customers to start using request-rate as default option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated. thanks!
|
||
2. Get Gen-AI Perf Tool | ||
|
||
Gen-AI Perf is available in the SDK container as shown in the [Send an Inference Request](#send-an-inference-request) section. The only difference is that you need to mount the converted dataset to the container: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link to me look likes is broken can you please confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the link works for me. maybe it is PR render issue on github
2. Get Gen-AI Perf Tool | ||
|
||
Gen-AI Perf is available in the SDK container as shown in the [Send an Inference Request](#send-an-inference-request) section. The only difference is that you need to mount the converted dataset to the container: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if you need to add installation section for GenAI-Perf here.
I created a smaple PR here for your reference: https://github.com/sgl-project/sglang/pull/3552/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the PR by utilizing the README you pointed. thanks!
If the first assumption holds true, the latency of speculative decoding will no worse than the standard approach. If the second holds, output token generation advances by statistically more than one token per forward pass. | ||
The combination of both these allows speculative decoding to result in reduced latency. | ||
|
||
## Performance Improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i woud like to see under what specific tasks would it be efficient to use. what kind of models should be used. draft models and the target model examples if any. I would like to see such recommendations.
Send out for a quick review within the team.
Will keep polishing