Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add tutorials on speculative decoding main page and EAGLE sub page #131

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ziqif-nv
Copy link
Contributor

Send out for a quick review within the team.

Will keep polishing

@ziqif-nv ziqif-nv changed the title add tutorials on speculative decoding main page and EAGLE sub page Docs: add tutorials on speculative decoding main page and EAGLE sub page Feb 15, 2025
@ziqif-nv ziqif-nv marked this pull request as draft February 15, 2025 00:14
@ziqif-nv ziqif-nv requested a review from ganeshku1 February 15, 2025 00:24
--input-file /data/converted_humaneval.jsonl \
--tokenizer /hf-models/vicuna-7b-v1.3/ \
--concurrency 1 \
--measurement-interval 4000 \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend to use request-rate option rather measurement interval as for long tests these are often requires longer stabalization window.
We are recommending GenAI-perf customers to start using request-rate as default option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. thanks!


2. Get Gen-AI Perf Tool

Gen-AI Perf is available in the SDK container as shown in the [Send an Inference Request](#send-an-inference-request) section. The only difference is that you need to mount the converted dataset to the container:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link to me look likes is broken can you please confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the link works for me. maybe it is PR render issue on github

2. Get Gen-AI Perf Tool

Gen-AI Perf is available in the SDK container as shown in the [Send an Inference Request](#send-an-inference-request) section. The only difference is that you need to mount the converted dataset to the container:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if you need to add installation section for GenAI-Perf here.
I created a smaple PR here for your reference: https://github.com/sgl-project/sglang/pull/3552/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the PR by utilizing the README you pointed. thanks!

If the first assumption holds true, the latency of speculative decoding will no worse than the standard approach. If the second holds, output token generation advances by statistically more than one token per forward pass.
The combination of both these allows speculative decoding to result in reduced latency.

## Performance Improvements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i woud like to see under what specific tasks would it be efficient to use. what kind of models should be used. draft models and the target model examples if any. I would like to see such recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants