Validate PlotData2D with LinearScalarAdvectionEquation3D
#2377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
DanielDoehring
requested changes
Apr 29, 2025
| @@ -691,6 +691,64 @@ end | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| @trixi_testset "PlotData2D gives correct results" begin | |||
There was a problem hiding this comment.
Suggested change
| @trixi_testset "PlotData2D gives correct results" begin | |
| @trixi_testset "PlotData2D" begin |
Usually we want most tests to give correct results :)
| scalar = c + A * sin(omega * sum(x_trans)) * exp(-2 * nu * omega^2 * t) | ||
| return SVector(scalar) | ||
| end | ||
| ic = initial_condition_diffusive_convergence_test |
There was a problem hiding this comment.
Suggested change
| ic = initial_condition_diffusive_convergence_test | |
| initial_condition = initial_condition_diffusive_convergence_test |
We keep it usually a little more verbose
Comment on lines
+719
to
+725
| @testset "Mesh Type: $mesh_type" for (mesh_type, mesh_fn) in [ | ||
| ("TreeMesh", () -> TreeMesh(coordinates_min, coordinates_max; | ||
| n_cells_max = 10^4, | ||
| initial_refinement_level=initial_refinement_level)), | ||
| coordinates_min, coordinates_max)) | ||
| ] | ||
| mesh = mesh_fn() |
There was a problem hiding this comment.
Is there a way to implement this using only mesh without the hazzle around mesh_fn()?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2377 +/- ##
==========================================
- Coverage 96.94% 93.58% -3.36%
==========================================
Files 502 502
Lines 41682 41676 -6
==========================================
- Hits 40405 39000 -1405
- Misses 1277 2676 +1399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to get started on #2335 based off of #2334 and #2340.