Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test environment with subpackages #76

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Fix test environment with subpackages #76

merged 2 commits into from
Feb 21, 2025

Conversation

tristanmontoya
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (b497b70) to head (2864f58).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files          22       22           
  Lines        2104     2104           
=======================================
  Hits         1902     1902           
  Misses        202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristanmontoya tristanmontoya marked this pull request as ready for review February 21, 2025 11:05
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if all tests pass!

@tristanmontoya tristanmontoya enabled auto-merge (squash) February 21, 2025 11:07
@tristanmontoya tristanmontoya merged commit 9603f94 into main Feb 21, 2025
10 checks passed
@tristanmontoya tristanmontoya deleted the tm/fix_tests branch February 21, 2025 11:07
@tristanmontoya tristanmontoya changed the title Fix test environment with package extensions Fix test environment with subpackages Feb 21, 2025
@@ -1,11 +1,15 @@
[deps]
NLsolve = "2774e3e8-f4cf-5e23-947b-6d7e65073b56"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need OrdinaryDiffeq.jl anymore if you update your examples accordingly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah, I think I will remove it in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants