Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2D manifold in 3D] Add routines to plot the vorticity for the 3D Cartesian SWE #57

Merged
merged 3 commits into from
Dec 3, 2024

Reorganized code and made convert_variables compatible with functions…

123e198
Select commit
Loading
Failed to load commit list.
Merged

[2D manifold in 3D] Add routines to plot the vorticity for the 3D Cartesian SWE #57

Reorganized code and made convert_variables compatible with functions…
123e198
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 3, 2024 in 0s

89.38% (-0.19%) compared to 4f26789

View this Pull Request on Codecov

89.38% (-0.19%) compared to 4f26789

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 12 lines in your changes missing coverage. Please review.

Project coverage is 89.38%. Comparing base (4f26789) to head (123e198).

Files with missing lines Patch % Lines
..._step/save_solution_2d_manifold_in_3d_cartesian.jl 85.71% 12 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   89.56%   89.38%   -0.19%     
==========================================
  Files          19       20       +1     
  Lines        1706     1790      +84     
==========================================
+ Hits         1528     1600      +72     
- Misses        178      190      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov