Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bottom topography and additional test cases for covariant shallow water equations #70

Closed
wants to merge 13 commits into from

Conversation

tristanmontoya
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 70.31250% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.75%. Comparing base (712f21b) to head (c768e4a).

Files with missing lines Patch % Lines
src/equations/reference_data.jl 0.00% 17 Missing ⚠️
...em_p4est/containers_2d_manifold_in_3d_covariant.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   90.39%   89.75%   -0.65%     
==========================================
  Files          22       22              
  Lines        2104     2158      +54     
==========================================
+ Hits         1902     1937      +35     
- Misses        202      221      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tristanmontoya
Copy link
Member Author

Closing as this should probably be separate from the changes in #53 and merged together afterwards.

@tristanmontoya tristanmontoya deleted the tm/bottom_topography branch February 7, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants