Implement Morris surface tension model #584
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 70.53% 70.22% -0.31%
==========================================
Files 96 96
Lines 5976 6143 +167
==========================================
+ Hits 4215 4314 +99
- Misses 1761 1829 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Conflicts: src/schemes/fluid/entropically_damped_sph/rhs.jl src/schemes/fluid/entropically_damped_sph/system.jl src/schemes/fluid/weakly_compressible_sph/system.jl test/schemes/fluid/fluid.jl
Conflicts: src/schemes/fluid/entropically_damped_sph/system.jl test/examples/examples.jl
Conflicts: src/schemes/fluid/entropically_damped_sph/system.jl
Conflicts: test/examples/examples.jl
Conflicts: test/examples/examples.jl
|
|
||
| ### Features | ||
|
|
||
| - Adds the classic **Continuum Surface Force (CSF)** model based on Morris 2000 (#584), which computes |
There was a problem hiding this comment.
Why bold? Nothing else is bold in this file.
There was a problem hiding this comment.
I have to add a PDF file to the publication database for which I can convert the NEWS.md file to a PDF.
| The computed curvature is then used to determine forces acting perpendicular to the interface. | ||
| While this method provides accurate surface tension forces, it does not explicitly conserve momentum. | ||
|
|
||
| In the Morris model, surface tension is computed based on local interface curvature ``\kappa`` and the unit surface normal ``\hat{n}``. |
There was a problem hiding this comment.
Not sure why the period is put in the next line. Can you maybe slightly reformulate this sentence?
There was a problem hiding this comment.
I will check after we have finished the review of the docs.
| ``` | ||
| This formulation focuses directly on geometric properties of the interface, making it relatively straightforward to implement when a reliable interface detection | ||
| (e.g., a color function) is available. However, accurately estimating ``\kappa`` and ``n`` may require fine resolutions. | ||
| --- |
There was a problem hiding this comment.
I will check tried to fix it.
Depends on #539
Depends on #604
Depends on #605
Depends on #606
Depends on #607
Depends on #608
Depends on #609
Depends on #599
super seeds #523