Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Morris surface tension model #584
base: main
Are you sure you want to change the base?
Implement Morris surface tension model #584
Changes from 250 commits
e079dc0
7f85a3f
b4c5ace
e555f03
6222872
dcc7001
0b3043c
3335386
7d4016c
28e9c2f
8837a5a
d8d6d4b
f9e2202
c6b0c72
77493f5
4192cf7
b15fe3e
1db1507
3065a5d
c47850b
aa53a4d
eefcd6c
9402b4a
f1de160
ba98d18
e0ede3e
d4016a6
7afffb4
3dfa4e4
1467107
fc4f61b
c4fcc16
e0eb153
33a704a
2533ed0
4899d08
d5e7c63
276436d
1781da0
2fb587d
eeca819
c18b774
514ffcf
223bcd0
f5dac70
cc50150
38ba683
5f96dab
9286097
b330a07
ca3a3c0
f73614e
14ec982
96e1cf6
bcfa0d8
d9227bb
747bf1c
3c5fd08
969dedd
c6371eb
4bf25e6
ebf6602
8659850
5b0ed25
7a6331e
3c80adf
4f66fa7
8faa548
2ba1902
503bc8b
801b274
d09b163
593c746
3180897
ba69a80
73b5749
67d5b87
f276a7b
b17a629
ad7a11f
7b076e6
23cbd38
537df19
cb227d5
20b77d7
d7b6af1
01bddb0
dc6fa70
28b28b8
ffc83d3
96d1a17
e424cfa
ec407ad
041861e
21f08b2
93067f3
0b63bca
4501847
b7f448c
a2cda84
ccf94c6
8851385
57ab0a6
a690b52
f4fbbb3
589d416
1263e1a
39a8f79
dd56f47
306f96d
eab49a1
7c7a1f0
2223ee8
9ad0526
93630aa
64396ef
2cc151c
9f758be
f74ac4e
170e314
3618010
ec75fab
d9325ad
1dfd1fe
cd26885
80e51ba
1141a12
4721aec
3a0413e
98a5f6c
e05edea
36741d7
ba8765f
c83c95e
9936e5d
4dc0cf8
5e83f0c
55e6557
ee5c2da
cfe7626
e174b1c
3398e91
fa6274d
2c9b033
8a413d6
43f2c56
fb70487
c737197
a411d1e
5f3c7ed
1c5afca
dafb7df
40d1e0a
1ce2af5
34c60ed
71d609f
73cfc8f
f90c5d3
7439e53
7da18f8
4b5a1ab
8b3f91b
2466eaa
a7764d2
f4b3c6f
ca0de6a
dd30511
32f12de
d64343a
4db3601
f7f8620
9924bac
e783541
6fd934e
5b2c988
9d92605
1ec50c8
41f69e4
9408a42
2defd31
aee3349
d438237
9681e08
21b92f8
face89a
540ee3f
1832335
6f1e8a9
97f3b06
3d1006a
0796b3f
bba3bd8
d4d4067
523c5e2
abcd3ac
1771434
f4088c0
65101db
a878534
c2f675e
648744e
e31e843
4a9e333
42b24ba
767eb9b
27b5089
fc73ebf
fddf47a
646fbfc
870ae4c
6f30a9a
b94742e
c9bd0bd
43c9670
d64982c
19f2e88
e229687
0982834
c1dfa83
c3b4474
657b530
43de9be
d992e67
aa0b985
133a515
ccd58bf
0e1efb5
0776aa7
1887aed
3eab67f
7c9ebb0
ecb9719
7fdc925
9cae162
ca322f1
081d2fb
50110be
dbf36c9
47cb6f5
0edf873
355d23e
ac1ce31
1d875ba
0de653d
9f568b0
cc14ce5
66d9e6a
204f848
bffab3e
6fd6a12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand "due to particle interactions".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good explanation! But a source would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For which part exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the rendered docs. C(r) above and A(r) below also don't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I missed them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the period is put in the next line. Can you maybe slightly reformulate this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check after we have finished the review of the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't render correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check tried to fix it.