-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the time integration method used in DualSPHysics and add docs for time integration #716
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 70.53% 70.50% -0.03%
==========================================
Files 96 97 +1
Lines 5976 5978 +2
==========================================
Hits 4215 4215
- Misses 1761 1763 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update News.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot
Can this only be used for WCSPH? It shouldn't be hard to add the EDAC scheme, right?
I mean, instead of evolving the density, we evolve the pressure.
using OrdinaryDiffEq | ||
sol = solve(ode, Euler(), | ||
dt=1.0, | ||
save_everystep=false, callback=callbacks); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention why we set save_everystep=false
?
You can always use the original |
|
||
### Features | ||
|
||
- The symplectic time integration scheme from DualSPHysics was added (#716) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The symplectic time integration scheme from DualSPHysics was added (#716) | |
- The symplectic time integration scheme based on DualSPHysics was added (#716) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The symplectic time integration scheme from DualSPHysics was added (#716) | |
- The symplectic time integration scheme used in DualSPHysics was added (#716) | |
Better maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fine
Supersedes #693.
Closes #683.
Find the rendered docs for this PR here:
https://trixi-framework.github.io/TrixiParticles.jl/previews/PR716/