Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132938 / 25.04 / Update empty config for disk list #11227

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

denysbutenko
Copy link
Member

Changes:

  • Added Retry button when dataProvider.load() thrown an error.
  • Added Reset button when empty search results in list.

Testing:

Simulate network error or try to clear empty search results.

@denysbutenko denysbutenko requested a review from a team as a code owner December 24, 2024 12:39
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team December 24, 2024 12:39
@bugclerk bugclerk changed the title NAS-132938: Update empty config for disk list NAS-132938 / 25.04 / Update empty config for disk list Dec 24, 2024
@bugclerk
Copy link
Contributor

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

For data reloading - would be nice to see some visual feedback. Currently there is no visual indicator.

Screen.Recording.2024-12-27.at.15.09.30.mov

@denysbutenko
Copy link
Member Author

Looks good. 👍

For data reloading - would be nice to see some visual feedback. Currently there is no visual indicator.

Screen.Recording.2024-12-27.at.15.09.30.mov

This is known issue will be solved separately

@denysbutenko denysbutenko enabled auto-merge (squash) December 27, 2024 13:42
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (57f6284) to head (b635051).
Report is 21 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../disks/components/disk-list/disk-list.component.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11227      +/-   ##
==========================================
- Coverage   82.51%   82.50%   -0.02%     
==========================================
  Files        1655     1655              
  Lines       58951    58961      +10     
  Branches     6091     6093       +2     
==========================================
+ Hits        48641    48643       +2     
- Misses      10310    10318       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft disabled auto-merge January 1, 2025 23:57
@undsoft undsoft merged commit 493273c into master Jan 1, 2025
8 of 9 checks passed
@undsoft undsoft deleted the NAS-132938 branch January 1, 2025 23:57
@bugclerk
Copy link
Contributor

bugclerk commented Jan 1, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants