-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132938 / 25.04 / Update empty config for disk list #11227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
For data reloading - would be nice to see some visual feedback. Currently there is no visual indicator.
Screen.Recording.2024-12-27.at.15.09.30.mov
This is known issue will be solved separately |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #11227 +/- ##
==========================================
- Coverage 82.51% 82.50% -0.02%
==========================================
Files 1655 1655
Lines 58951 58961 +10
Branches 6091 6093 +2
==========================================
+ Hits 48641 48643 +2
- Misses 10310 10318 +8 ☔ View full report in Codecov by Sentry. |
This PR has been merged and conversations have been locked. |
Changes:
Retry
button whendataProvider.load()
thrown an error.Reset
button when empty search results in list.Testing:
Simulate network error or try to clear empty search results.