Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131912 / 25.04 / Adapt to back-end changes in disk stats #11234

Merged
merged 3 commits into from
Jan 1, 2025

Conversation

bvasilenko
Copy link
Contributor

Testing:

Go to Reporting > Disk and ensure that the stats are displayed correctly

@bvasilenko bvasilenko requested a review from a team as a code owner December 25, 2024 06:53
@bvasilenko bvasilenko requested review from denysbutenko and removed request for a team December 25, 2024 06:53
@bugclerk bugclerk changed the title NAS-131912: Adapt to back-end changes in disk stats NAS-131912 / 25.04 / Adapt to back-end changes in disk stats Dec 25, 2024
@bugclerk
Copy link
Contributor

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.82%. Comparing base (74755a4) to head (bb47c5f).
Report is 37 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/admin.routes.ts 0.00% 2 Missing ⚠️
src/app/pages/reports-dashboard/reports.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11234      +/-   ##
==========================================
+ Coverage   82.46%   82.82%   +0.35%     
==========================================
  Files        1650     1655       +5     
  Lines       58697    58977     +280     
  Branches     6073     6117      +44     
==========================================
+ Hits        48407    48846     +439     
+ Misses      10290    10131     -159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The heading text could be improved. It works great.

@undsoft undsoft merged commit 56d6ba9 into master Jan 1, 2025
8 of 9 checks passed
@undsoft undsoft deleted the NAS-131912 branch January 1, 2025 23:57
@bugclerk
Copy link
Contributor

bugclerk commented Jan 1, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants