Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133239 / 25.04 / Remove highlighting when user interacts with a page #11237

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Result:

NAS-133239.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 25, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 25, 2024 09:43
@AlexKarpov98 AlexKarpov98 requested review from RehanY147 and removed request for a team December 25, 2024 09:43
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-133239: Remove highlighting when user interacts with a page NAS-133239 / 25.04 / Remove highlighting when user interacts with a page Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (2321cec) to head (09374e4).
Report is 18 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gate-and-interact/navigate-and-interact.service.ts 10.34% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11237      +/-   ##
==========================================
- Coverage   82.49%   82.48%   -0.01%     
==========================================
  Files        1651     1651              
  Lines       58738    58747       +9     
  Branches     6073     6073              
==========================================
+ Hits        48457    48460       +3     
- Misses      10281    10287       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice!

@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) December 28, 2024 23:43
@AlexKarpov98 AlexKarpov98 merged commit 68fdc48 into master Dec 28, 2024
8 of 9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-133239 branch December 28, 2024 23:44
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants