Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133262 / 25.04 / Fix more strict null issues #11240

Merged
merged 4 commits into from
Dec 28, 2024

Merge branch 'master' of github.com:truenas/webui into NAS-133262

b5d591f
Select commit
Loading
Failed to load commit list.
Merged

NAS-133262 / 25.04 / Fix more strict null issues #11240

Merge branch 'master' of github.com:truenas/webui into NAS-133262
b5d591f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 26, 2024 in 0s

82.51% (+0.00%) compared to 35832d8

View this Pull Request on Codecov

82.51% (+0.00%) compared to 35832d8

Details

Codecov Report

Attention: Patch coverage is 86.95652% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.51%. Comparing base (35832d8) to head (b5d591f).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ivilege/privilege-list/privilege-list.component.ts 33.33% 2 Missing ⚠️
...options-section/other-options-section.component.ts 85.71% 1 Missing ⚠️
...missions/utils/nfs-ace-to-permission-item.utils.ts 75.00% 1 Missing ⚠️
src/app/pages/jobs/jobs-list.component.ts 0.00% 1 Missing ⚠️
.../iscsi/target/all-targets/all-targets.component.ts 0.00% 1 Missing ⚠️
...pages/storage/modules/devices/devices.component.ts 0.00% 1 Missing ⚠️
...ystem/alert-settings2/alert-settings2.component.ts 0.00% 1 Missing ⚠️
.../enclosure-page/pools-view/pools-view.component.ts 0.00% 1 Missing ⚠️
...instance-edit-form/instance-edit-form.component.ts 0.00% 1 Missing ⚠️
...rtualization/stores/virtualization-config.store.ts 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11240   +/-   ##
=======================================
  Coverage   82.50%   82.51%           
=======================================
  Files        1655     1655           
  Lines       58943    58950    +7     
  Branches     6091     6108   +17     
=======================================
+ Hits        48633    48640    +7     
  Misses      10310    10310

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov