Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133107 / 25.04 / Apps UI, when apps are filtered continues to show prior selection details, even when not shown in the list #11248

Merged
merged 1 commit into from
Jan 1, 2025
Merged

NAS-133107 / 25.04 / Apps UI, when apps are filtered continues to show prior selection details, even when not shown in the list #11248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/app/pages/apps/components/installed-apps/installed-apps.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,14 @@
[selectedItem]="selectedApp"
>
<ix-installed-apps-list
#installedAppsList
master
[isMobileView]="masterDetailView.isMobileView()"
(toggleShowMobileDetails)="masterDetailView.toggleShowMobileDetails($event)"
></ix-installed-apps-list>

<ng-container detail-name>
{{ selectedApp?.name }}
</ng-container>

<ng-container detail>
@if (selectedApp) {
@if (selectedApp && (!installedAppsList.filterString || selectedApp.name.toLowerCase().includes(installedAppsList.filterString.toLowerCase()))) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap it in computed property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, was not able to make it work via computed prop.

<ix-app-details-panel
[app]="selectedApp"
(startApp)="start(selectedApp.name)"
Expand Down
Loading