-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-134329 / 25.10 / Show core.download job errors #11662
Conversation
# Conflicts: # src/assets/i18n/it.json
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11662 +/- ##
==========================================
+ Coverage 83.38% 83.48% +0.09%
==========================================
Files 1660 1660
Lines 59318 59237 -81
Branches 6415 6414 -1
==========================================
- Hits 49464 49452 -12
+ Misses 9854 9785 -69 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-134329 is targeted to the following versions which have not received their corresponding PRs: 25.04.0 |
This PR has been merged and conversations have been locked. |
Changes:
core.download
returns a job, which we didn't wait for to complete previously in most cases.Testing:
Check file downloads in the UI.
You can also check error handling by supplying incorrect arguments in
coreDownload
in some jobs.