Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-134329 / 25.10 / Show core.download job errors #11662

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Mar 4, 2025

Changes:

core.download returns a job, which we didn't wait for to complete previously in most cases.

Testing:

Check file downloads in the UI.
You can also check error handling by supplying incorrect arguments in coreDownload in some jobs.

@undsoft undsoft requested a review from a team as a code owner March 4, 2025 09:56
@undsoft undsoft requested review from RehanY147 and removed request for a team March 4, 2025 09:56
@bugclerk bugclerk changed the title NAS-134329: Show core.download job errors NAS-134329 / 25.10 / Show core.download job errors Mar 4, 2025
@bugclerk
Copy link
Contributor

bugclerk commented Mar 4, 2025

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.48%. Comparing base (f281d7c) to head (a22b1a8).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ority-list/certificate-authority-list.component.ts 0.00% 2 Missing ⚠️
...ash/certificate-list/certificate-list.component.ts 0.00% 2 Missing ⚠️
...s/certificates-dash/csr-list/csr-list.component.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11662      +/-   ##
==========================================
+ Coverage   83.38%   83.48%   +0.09%     
==========================================
  Files        1660     1660              
  Lines       59318    59237      -81     
  Branches     6415     6414       -1     
==========================================
- Hits        49464    49452      -12     
+ Misses       9854     9785      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@undsoft undsoft merged commit ce23e14 into master Mar 5, 2025
9 checks passed
@undsoft undsoft deleted the NAS-134329 branch March 5, 2025 12:24
@bugclerk
Copy link
Contributor

bugclerk commented Mar 5, 2025

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-134329 is targeted to the following versions which have not received their corresponding PRs: 25.04.0

@bugclerk
Copy link
Contributor

bugclerk commented Mar 5, 2025

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants