(Fix): Fix setting vars to false and add testing framework #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
IMO, it's probably a bit easier if we did this with Python, but I think we need tests like this ASAP 👍 Thank you so much
There was a problem hiding this comment.
Sounds good. Not gonna rewrite rn, but not at all opposed to someone doing so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because variables like
use-quarantiningare currently defaulting to true, we didn't have a way to set these flags to false. Applies that fix.Also creates a lightweight jest testing framework that just runs
script.shwith minimal environment variables and asserts on the invocation command. This generates ajunit.xml, and then the actual GH Action is invoked as part of a PR job.We will probably want to add to the integration/pr tests with a matrix of different inputs, but I think this is a good start. We also have plenty of other coverage of
mainelsewhere, although we don't currently recommend users have a tag.