Skip to content

Commit

Permalink
chore: purge mentions of jest, and specify jest-dom/vitest import (#2805
Browse files Browse the repository at this point in the history
)
  • Loading branch information
werdnanoslen authored Mar 6, 2024
1 parent e77fe30 commit 9ca4bdc
Show file tree
Hide file tree
Showing 5 changed files with 689 additions and 885 deletions.
1 change: 0 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"browser": true,
"commonjs": true,
"es6": true,
"jest": true,
"node": true
},
"parserOptions": {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install dependencies
run: yarn --frozen-lockfile

- name: Run Jest tests with coverage
- name: Run tests with coverage
run: yarn test:coverage

- name: Run node server side tests
Expand Down
4 changes: 2 additions & 2 deletions docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ These should all be run from within the project directory.
- Starts Storybook server and watches for changed files
- This will most likely be what you use for active development of components
- `yarn test`
- Starts Jest test runner
- Starts test runner
- `yarn test:watch` is also available
- Use `yarn test:coverage` to generate a coverage report
- `yarn build`
Expand Down Expand Up @@ -96,7 +96,7 @@ Because this project exports a library that will be used by other projects, it i
- Package dependency changes should include `yarn.lock` updates and
`yarn audit` will be run by danger to ensure no high or critical
vulnerabilities are found
- [Jest tests](https://jestjs.io/) are run in CI and must pass before the branch can be merged
- [Vite tests](https://vitest.dev/) are run in CI and must pass before the branch can be merged
- [Happo.io visual regression tests](https://docs.happo.io/docs/reviewing-diffs) are run CI against Storybook stories. All diffs must be approved before the branch can be merged. Developers with access (maintainers and many codeowners) log in to Happo.io account to approve/reject diffs.
- PR titles must follow conventional commits specification.
- We use [release-please](https://github.com/googleapis/release-please). This auto-generates version numbers and changelog based on commits. We [squash & merge](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-merges#squash-and-merge-your-pull-request-commits) PR commits, so the title must be correct.
Expand Down
2 changes: 1 addition & 1 deletion src/setupTests.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import '@testing-library/jest-dom'
import '@testing-library/jest-dom/vitest'
import { cleanup } from '@testing-library/react'

vi.mock('focus-trap-react')
Expand Down
Loading

0 comments on commit 9ca4bdc

Please sign in to comment.