-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Made storybook docs available again, small org changes elsewhere #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also flattened them by removing the "authentication pages" folder
involves some package use changes
AnnaGingle
previously approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
gidjin
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@werdnanoslen Hey there, did this go live? I'm not seeing the Docs on components like Textarea: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The latest update to storybook saw a "feature" moving docs from a consistent tab to a new page for each component. The main change here changes
.storybook/main.ts
to make that available for all pages and modifies the global storybook[-docs] params to use the right fonts. However, we don't want the docs treatment for the welcome page, so I refactored that as a .mdx file, so now that appears as it did before with the benefit it being much simpler markdown file. This also required the Templates folder to be flattened, as the sub-folder Authentication Pages could only have onedocs
page.I also moved the Link out of its lonely Typography folder and the TimePicker out of its deprecated
form controls
folderRelated Issues or PRs
None
How To Test
Check that all components and template pages have the same docs as before, just in a page instead of a tab
Screenshots (optional)