feat: Upgrade to React 19 #3088
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aligg
commented
Dec 23, 2024
| "stylelint-config-css-modules": "^4.4.0", | ||
| "stylelint-config-prettier": "^9.0.5", |
There was a problem hiding this comment.
ℹ️ all style-related rules have been deprecated as of stylelint 15 so this plugin is no longer necessary. Additionally, the older version has some conflicts with the other dependencies we need to update.
|
This is awesome! |
6 tasks
|
@brandonlenz are you the best person to review this PR? |
|
Can confirm this works with React 19. You can see our upgrade PR here: HHS/simpler-grants-gov#3515 . Would be great to get this pulled in 🚀 |
sbolel
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
LGTM, though it like the fonts changed a bit in the snapshot tests: https://happo.io/a/371/p/453/compare/931d2456d1b97c73a54aa598f8bfd7ba1fa50531/58f3089739ac5ee415c11cfbe179daad7a625971
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related PR
#3045
I know @sbolel has a PR up in progress - feel free to defer to that one. I had some time this morning to get this working though.
How To Test
Screenshots (optional)
N/A