Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#150 Introduces breaking changes. While I believe the changes should exist, short of quite a bit more effort, there isn't an upgrade path for users of the existing module where the changes that exist in this update provide. So this is a compromise.
I had imagined cutting two releases.
v10.1.0
(this one) which would allow users of the existing module to reap these benefits without further work (maybe setting appropriate variables).v11.0.0
(BREAKING_CHANGES: V11 #150). This would allow anyone adopting the module for the first time to not have to deal with the breaking changes that exist as a result of the changes.Long-term, I don't want to manage two branches.
I can add something to the existing
README
on both releases that talks about the versions and usage for both.Closes:
Additions:
logs_s3_bucket
, the boolenable_access_logs
andenable_connection_logs
(both default tofalse
) need to be set totrue
to enable logging of either type.alb_ssl_policy
toELBSecurityPolicy-TLS13-1-2-2021-06
.enable_waf_fail_open
with a default value offalse
.preserve_host_header
variable with a default value offalse
.drop_invalid_host_headers
variable with default value oftrue
.POTENTIAL BREAKING CHANGES
~> 5.0
.General Housekeeping
.pre-commit-config.yaml
because it is not possible to ignore theexamples
directory. So a targetcheck
has been added to theMakefile
.check-jsonschema
pre-commit for.pre-commit-config.yaml
,.markdownlint.yml
andrenovate
along withgithub-workflows
(which is their name for Actions).terraform-docs-system
which has an expectation thatterraform-docs
is installed locally. This also uses the official GitHub Action but there is a bug. So across the org, I've tried to find the right configuration adopting the official action along with pre-commit-hook and making it work everywhere. I believe this combination works.terraform-docs
will still continue to work locally, but in GitHub Actions, we pass an ENV VAR ofSKIP=terraform-system-go
to not callterraform-docs
a second time via pre-commit.