fix(flags): change findUnique to findFirst for feature flag retrieval…

… and enhance user validation
tryabby · Feb 17, 2025 · b78c5f7 · b78c5f7
1 parent e2c2780
commit b78c5f7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/apps/web/src/server/trpc/router/flags.ts b/apps/web/src/server/trpc/router/flags.ts
@@ -493,9 +493,18 @@ export const flagRouter = router({
       })
     )
     .query(async ({ ctx, input }) => {
-      return ctx.prisma.featureFlagValue.findUnique({
+      return ctx.prisma.featureFlagValue.findFirst({
         where: {
           id: input.flagValueId,
+          flag: {
+            project: {
+              users: {
+                some: {
+                  userId: ctx.session.user.id,
+                },
+              },
+            },
+          },
         },
         include: {
           environment: true,

diff --git a/packages/core/src/validation/index.ts b/packages/core/src/validation/index.ts
@@ -86,7 +86,7 @@ export function validate<T extends Record<string, ValidatorType>>(
       continue;
     }
 
-    returnObject[key] = value as Infer<typeof validator>;
+    returnObject[key] = value as Infer<T[typeof key]>;
   }
   if (errors.length > 0) {
     return { errors };