changed inclusive bound threshold detection to right exclusive bounds

Author: JZauner

NEWS.md

@@ -1,3 +1,5 @@
+* changed the behavior of all metric functions that calculate an in-between value (such as the duration of light between 250 and 1000 lux). Up until now, the function would use inclusive bounds on both sides, i.e. the value of 250 lux and 1000 lux would be included in the calculation. This is now changed to right exclusive bounds, i.e. the value of 250 lux will still be included in the calculation, whereas 1000 lux will not. While of little practical difference in a realistic dataset (where exact values matching the threshold are likely not present), it is relevant when calculating, e.g., the time spent in various levels of light or any other variable. The sum of those times should always add up to the total time. With inclusive bounds on both sides, the sum could theoretically be larger, with right exclusive bounds it cannot.
+
 * Import support for the `ClouClip` device.
 
 * `import_Dataset()` no longer changes a pre-existing `Id` column (if it is not called `Id`). The function is also more informative for the daylight savings time handling in files with more than one Id.

R/helper.R

@@ -109,7 +109,7 @@ compare_threshold <- function(Light.vector,
   }
   else{
     threshold <- sort(threshold)
-    out <- Light.vector >= threshold[1] & Light.vector <= threshold[2]
+    out <- Light.vector >= threshold[1] & Light.vector < threshold[2]
   }
 
   if(na.replace){