Escape quotes in video description #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttillberg
reviewed
Jun 29, 2020
ttillberg
reviewed
Jun 29, 2020
| return; | ||
| } | ||
|
|
||
| var escaped = str.split(String.fromCharCode(92)).join(String.fromCharCode(92,92)); |
There was a problem hiding this comment.
The problem I can see with this is that by escaping "" you could end up with "\\\" if you load, then save the value over again? Have you tested this?
There was a problem hiding this comment.
Curious about benefits of fromCharCode(92) over a replace(/\\/g,). Escaping is hell (alongside date conversions). Is this the holy grail? ✨ :
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Videos with double quotes in the description were failing to output the JSON correctly.