feat: make XcodeMetadata a product of the package
#204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies Package.swift to declare "XcodeMetadata" as a valid library product so that it can be used downstream, addressing implicit import detection issues.
- Added a library product declaration for "XcodeMetadata"
- Ensured that dependency resolution works correctly for downstream targets
fortmarek
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The detection of implicit imports fails in this PR because
XcodeMetadatais not explicitly declared as a dependency, but I can't declare it because it's actually not defined as a product here.I'm adjusting the
Package.swiftto make the target also a valid product that can be used downstream.