Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add folder selection functionality for model directories. #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LlamaEnjoyer
Copy link
Contributor

Another (hopefully) useful qol feat: users can now manually point to the model folder via button:

image

@turboderp
Copy link
Member

I'm a little unsure about this one. I had originally wanted a folder select button, but browsers simply don't allow it (for obvious security reasons.) Using tkinter is one option, but launching a dialog on the server wouldn't really work if the server and client browser aren't running on the same device. I know a bunch of people use headless servers, or even cloud servers, so I'm just not sure this is the right approach.

@LlamaEnjoyer
Copy link
Contributor Author

Understandable, I can always keep it on my own branch for private use. If you ever think of a better approach feel free to pont me there and I'll see if it's something I can implement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants