Refactor new relation sync #11711
Open
Refactor new relation sync #11711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored workspace relation synchronization logic with improved join column handling and dynamic relation support.
- Added optional
joinColumnproperty inWorkspaceRelationMetadataArgsinterface for explicit join column specification - Removed relation-type filtering in
getOriginalObjectMetadataCollection, now fetches all fields which may impact performance - Renamed
updateFieldRelationMetadatatocomputeFieldRelationMetadataFromDecoratorsfor better clarity - Added support for dynamic relations through
workspaceDynamicRelationMetadataArgsCollection - Improved join column handling with direct
joinColumnproperty check inStandardFieldRelationFactory
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
233
to
238
| await objectMetadataRepository.find({ | ||
| where: { | ||
| workspaceId: context.workspaceId, | ||
| fields: { | ||
| type: FieldMetadataType.RELATION, | ||
| }, | ||
| }, | ||
| relations: ['dataSource', 'fields'], | ||
| }); |
There was a problem hiding this comment.
style: Removing the relation type filter here will fetch all fields from the database instead of just relation fields. Consider keeping the filter to optimize database queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.