Fix crash when hiding a column in Kanban view #11847
Merged
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed a crash in the Kanban view when hiding columns by properly wrapping the 'HiddenGroups' SelectableListItem with a SelectableList component to provide necessary context for Recoil state management.
- Modified
packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownRecordGroupsContent.tsxto wrap HiddenGroups SelectableListItem with SelectableList - Added missing selectableListInstanceId context required for recoil state management
- Fixed issue Kanban - Page crashes after hiding a column in Kanban view #11828 where hiding Kanban columns would trigger "Instance id is not provided" error
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
189
to
191
| selectableListInstanceId={OBJECT_OPTIONS_DROPDOWN_ID} | ||
| hotkeyScope={TableOptionsHotkeyScope.Dropdown} | ||
| selectableItemIdArray={['HiddenGroups']} |
There was a problem hiding this comment.
logic: Using same selectableListInstanceId (OBJECT_OPTIONS_DROPDOWN_ID) as parent SelectableList could cause conflicts in state management
Suggested change
| selectableListInstanceId={OBJECT_OPTIONS_DROPDOWN_ID} | |
| hotkeyScope={TableOptionsHotkeyScope.Dropdown} | |
| selectableItemIdArray={['HiddenGroups']} | |
| selectableListInstanceId={`${OBJECT_OPTIONS_DROPDOWN_ID}-hidden`} | |
| hotkeyScope={TableOptionsHotkeyScope.Dropdown} | |
| selectableItemIdArray={['HiddenGroups']} |
|
Thanks @abdulrahmancodes for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When hiding a kanban view column, users encountered the following error:
Instance id is not provided and cannot be found in context.This was caused by the
SelectableListItemfor the "HiddenGroups" menu item not being wrapped in aSelectableList. As a result, the required context (specifically, the selectableListInstanceId) was missing, leading to errors in recoil state management.Solution
This PR wraps the "HiddenGroups"
SelectableListItemin its ownSelectableListcomponent, providing the necessary context and ensuring that the component family selectors work as expected.Screen.Recording.2025-05-03.at.8.30.24.AM.mov
Closes #11828