Fix members table column alignment #12298
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Modified workspace members table layout in packages/twenty-front/src/pages/settings/SettingsWorkspaceMembers.tsx to improve column alignment and spacing.
- Changed grid column proportions from
150px 1fr 1frto3fr 1fr 1frfor better email column width - Removed right alignment from 'Expires in' column for consistent chip alignment
- Adjusted table header and cell alignments to match design requirements
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:44040 This environment will automatically shut down when the PR is closed or after 5 hours. |
There was a problem hiding this comment.
Hi @DivyanshuLohani 👋 Thank you for your contribution :)
It looks good but does not work as expected with long email ⬇️
| @@ -308,21 +308,21 @@ export const SettingsWorkspaceMembers = () => { | |||
| {isNonEmptyArray(workspaceInvitations) && ( | |||
| <StyledTable> | |||
| <TableRow | |||
| gridAutoColumns="150px 1fr 1fr" | |||
There was a problem hiding this comment.
Can you try increasing to 300px ?
| <Trans>Expires in</Trans> | ||
| </TableHeader> | ||
| <TableHeader></TableHeader> | ||
| </TableRow> | ||
| <StyledTableRows> | ||
| {workspaceInvitations?.map((workspaceInvitation) => ( | ||
| <TableRow | ||
| gridAutoColumns="150px 1fr 1fr" |
| mobileGridAutoColumns="100px 1fr 1fr" | ||
| > | ||
| <TableHeader> | ||
| <Trans>Email</Trans> | ||
| </TableHeader> | ||
| <TableHeader align={'right'}> |
| @@ -337,7 +337,7 @@ export const SettingsWorkspaceMembers = () => { | |||
| {workspaceInvitation.email} | |||
| </StyledTextContainerWithEllipsis> | |||
| </TableCell> | |||
| <TableCell align={'right'}> | |||
|
Sorry I am new to contributing I didn't test it well my bad |
|
Thanks @DivyanshuLohani for your contribution! |
Fixes: twentyhq#12287  --------- Co-authored-by: Divyanshu Lohani <DivyanshuLohani@users.noreply.github.com> Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
Fixes: twentyhq#12287  --------- Co-authored-by: Divyanshu Lohani <DivyanshuLohani@users.noreply.github.com> Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
Fixes: twentyhq#12287  --------- Co-authored-by: Divyanshu Lohani <DivyanshuLohani@users.noreply.github.com> Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
Fixes: twentyhq#12287  --------- Co-authored-by: Divyanshu Lohani <DivyanshuLohani@users.noreply.github.com> Co-authored-by: etiennejouan <jouan.etienne@gmail.com>
Fixes: #12287