adding new error codes to the temporary catch #12366
Open
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:49238 This environment will automatically shut down when the PR is closed or after 5 hours. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error handling for Gmail and Microsoft messaging services by adding explicit handling of server-side error status codes (503, 502, 504, 509) as temporary errors.
- Added dedicated case for 503 status code in
/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts - Expanded Microsoft error handling in
/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.tsto include 503 and 509 status codes - Added handling for 'Authentication backend unavailable' errors with formatted messages for Gmail services
- Implemented consistent TEMPORARY_ERROR classification for server-side issues across both Gmail and Microsoft implementations
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...ging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts
Show resolved
Hide resolved
ijreilly
reviewed
May 30, 2025
...ging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft, examples of errors from the logs:
Fixes #12252