Fix hotkey scope in settings #12387
Merged
Fix hotkey scope in settings #12387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR simplifies hotkey management by consolidating page scopes and disabling shortcuts in settings pages to resolve conflicts, particularly in the GraphQL playground.
- Simplified
PageHotkeyScopeenum by replacing specific page scopes (ShowPage, PersonShowPage, etc.) with a genericRecordShowPagescope - Modified
PageChangeEffectto use a single restrictive settings scope instead of multiple specific ones - Removed
OpportunitiesPageandTasksPagehotkey scopes fromuseShowAuthModaltest cases - Changed
DEBUG_HOTKEY_SCOPEto true, though this might not be the optimal solution for disabling settings shortcuts
4 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| @@ -1 +1 @@ | |||
| export const DEBUG_HOTKEY_SCOPE = false; | |||
| export const DEBUG_HOTKEY_SCOPE = true; | |||
There was a problem hiding this comment.
logic: Enabling debug mode by default could expose debugging information and affect hotkey behavior across the application. Consider using a more targeted approach to disable hotkeys in specific scopes.
Comment on lines
+188
to
196
| case location.pathname.startsWith(AppBasePath.Settings): { | ||
| setHotkeyScope(PageHotkeyScope.Settings, { | ||
| goto: false, | ||
| keyboardShortcutMenu: true, | ||
| }); | ||
| break; | ||
| } | ||
| case isMatchingLocation( | ||
| location, | ||
| SettingsPath.WorkspaceMembersPage, | ||
| AppBasePath.Settings, | ||
| ): { | ||
| setHotkeyScope(PageHotkeyScope.WorkspaceMemberPage, { | ||
| goto: true, | ||
| keyboardShortcutMenu: true, | ||
| keyboardShortcutMenu: false, | ||
| commandMenu: false, | ||
| commandMenuOpen: false, | ||
| }); | ||
| break; | ||
| } |
There was a problem hiding this comment.
style: Disabling all hotkey functionality in settings might be too restrictive - consider keeping basic navigation shortcuts
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:62925 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
May 31, 2025
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
Jun 1, 2025
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.
jordan-chalupka
pushed a commit
to InsurOS/twenty
that referenced
this pull request
Jun 1, 2025
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many conflicts on hotkey scopes (e.g. we still had the issue on the graphql playground). Let's disable all shortcuts in settings.