Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CS #4581

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Fix CS #4581

merged 1 commit into from
Feb 14, 2025

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Feb 14, 2025

No description provided.

@fabpot fabpot merged commit cfeb51b into twigphp:3.x Feb 14, 2025
39 of 41 checks passed
@fabpot fabpot deleted the cs-fixes branch February 14, 2025 11:59
@@ -46,9 +46,6 @@ public function count()
return mb_strlen($this->content, $this->charset);
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot Looks like Symfony's DebugClassLoader is not happy with this change: https://github.com/symfony/symfony/actions/runs/13329105184/job/37228898654?pr=59776#step:8:2832

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #4582

@xabbuh xabbuh mentioned this pull request Feb 14, 2025
fabpot added a commit that referenced this pull request Feb 14, 2025
This PR was merged into the 3.x branch.

Discussion
----------

re-add mixed return type

see #4581 (comment) and https://github.com/symfony/symfony/actions/runs/13329105184/job/37228898654?pr=59776#step:8:2832

Commits
-------

5f6c67f re-add mixed return type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants