Remove template source from Template::loadTemplate() #4583
+100
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test does not ensure the issue is solved as it asserts only the exception message, not the exception location. |
Yes, I know, I will update it. |
smnandre
reviewed
Feb 20, 2025
fabpot
force-pushed
the
loadTemplate-source
branch
from
eafd274 to
850117a
Compare
fabpot
force-pushed
the
loadTemplate-source
branch
from
850117a to
e20b4bb
Compare
|
@stof Should be good now. |
fabpot
force-pushed
the
loadTemplate-source
branch
from
e20b4bb to
8100661
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3266
The first commit supports string and Source. But I think we don't even need to pass anything (that's the other commits).