Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds as_json to response objects that inherit from Domain. #556

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Adds as_json to response objects that inherit from Domain. #556

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7723e37
Adds to_json to response objects that inherit from Domain.
rhuberdeau May 12, 2021
2652b5b
Merge branch 'main' into feature/add_to_json_support
thinkingserious Jun 16, 2021
c471e30
Merge branch 'main' into feature/add_to_json_support
thinkingserious Jun 17, 2021
5b97bf7
Adds initial test for as_json.
rhuberdeau Jun 17, 2021
b846b47
Merge branch 'feature/add_to_json_support' of https://github.com/rhub…
rhuberdeau Jun 17, 2021
c569ae5
Fixes namespace issue in test.
rhuberdeau Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/twilio-ruby/framework/domain.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ def request(method, uri, params = {}, data = {}, headers = {}, auth = nil, timeo
timeout
)
end

def as_json(*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be to_json or as_json?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be as_json.

I tested this by updating the gem, locally, and then point my app to the local install. At that point my application did not get an error when calling to_json on an insights object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a suitable unit test would be to ensure that the data returned by this function is as expected, located here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rhuberdeau,

Just checking back in. Would you like us to take it from here or is this still WIP? Thanks!

@properties
end
end
end
end